Submitted about 1 year ago
it's an intro component with a sign-up form, using HTML, CSS, JS
@yassmine23
Design comparison
SolutionDesign
Solution retrospective
I'm looking forward your feedbacks!
Community feedback
- @ledesmxPosted about 1 year ago
Hi Yasmin ๐
Great job on your solution!
Here are some recommendations for you:
- I found that there are two background images when the screen's width is shorter than 650px. Because the background images are rendered in two different elements (
body
and.container
). I suggest removing one of them:
@media (max-width: 650px) { .container { background-image: url(images/bg-intro-mobile.png); /*Remove this*/ } }
- Whether you want to render one background or the other. You can add the media query for the
body
tag. Like this:
body { background-image: url(images/bg-intro-desktop.png); } @media (max-width: 650px) { /*Add this media query*/ body { background-image: url(images/bg-intro-mobile.png); } }
I hope this helps a little.
Well done for the rest.
0 - I found that there are two background images when the screen's width is shorter than 650px. Because the background images are rendered in two different elements (
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord