@Abbassher55
Posted
Hello, great job overall! However, I noticed a couple of issues:
-
In the design, there is no border radius applied to the right side of the image and applied to both left top and left bottom side ( You have applied to the top left and top right ).
-
In the active state of the design, the "Add to Cart" button should change its background color to a darker shade of green.
Apart from that, you have done a good job.
@yusufskebbe
Posted
Thank you for feedbaxk i add the hover effect and push it to my github , Mr.Abbas i wonder if you did this challenge how did you manage this width and height for image and the card , do you have an idea because for me it took alot of time @Abbassher55
@Abbassher55
Posted
@yusufskebbe
I will work on it now when i have time .
First i will center a div which have class card and then i will divide the card into two divs with equal size. Now when u put the image in the first div u can add width 100% property so the image will be inside that div and will not overflow also if the image doesnt look good so u can add object-fit property with value either cover or contain.
This is some idea for desktop sizes and u can use media queries for other screens.
I will work on it soon so follow me to see this and i will use tailwind css as i am currently learning that
