It was easy but unfortunately I have't learned a Responsive web design

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="margin"> with the main tag and <p class="p1"> with <h1> to fix the accessibility issue. click here for more on web-accessibility and semantic html

  Give the alt attribute in the img a value. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  There is no need to style .margin.

  To center .main on the page using flexbox or grid instead of margin, , add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  USING FLEXBOX:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  USING GRID:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Give h1 and p the same font-size of 15px which is 0.9375rem, text-align: center , the same margin-left, margin-right and margin-top values. Give p a margin bottom value and font-color of hsl(220, 15%, 55%); for the faded color.

  Give the img a max-width of 100% for a responsive image and a border-radius value, the rest are not needed.

  For a responsive content, replace the height in .main with a padding value for all the sides and the width with max-width and its increase the value for it to be equivalent to the design. max-width: 320px padding: 16px

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0