Is a solution to the NFT preview card component using hover.

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Stalin,

  Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:

  HTML

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • You should have used <a> to wrap Equilibrium #3429 and Jules Wyvern too.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in icon-view, icon-clock, icon-ethereum.

  • Profile images like that avatar are valuable content. The alternate text should not be empty .You can use the creator's name Jules Wyvern. Read more how to write an alt text .

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.

  • Remember a modern css reset on every project that make all browsers display elements the same.

  • Really important to keep css specificity as low/flat as possible. It’s not recommended to use the ids to target the DOM elements for styling purposes, better to use classes so that it could be more manageable and reusable.IDs have a much higher specificity than classes) IDs have many uses in a webpage aside from being a CSS selector. For example as page anchors, fragment identifiers or to link labels to form fields.

  • Consider using min-height: 100vh instead of height: 100vh to the body , that let the body grows taller if the content of the page outgrows the visible page.

  • There are so many arguments against setting the root font-size: 62%it state that you should never change the root font size because it harms accessibility.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute, you can expose your site to performance and security issues.

  Hopefully this feedback helps.

  0
• 

  Yefry Sanchez•330

  @y25sanchezPosted about 2 years ago

  To fix the hover effect on the image you can create a new div with an id of layer inside of the "img-container" and then apply this styles:

  #layer{
      width: 100%;
      height: 100%; 
      opacity: 0;
      transition: background-color 0.5s, opacity 0.5s;
  }
  #layer:hover{
      opacity: 1;
      background-image: url(/images/icon-view.svg);
      background-repeat: no-repeat;
      background-color: var(--Cyan-eye); 
      background-position: center;
      cursor: pointer;
  } 
  

  0