ip-tracker with vue 3 and vuex

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  Nice job so far on this project. Here are a few things to look at:

  • I can search using the ip address but not the dormain name.
  • A form control does not have a corresponding label. If a form control does not have a properly associated text label, the function or purpose of that form control may not be presented to screen reader users. Form labels also provide visible descriptions and larger clickable targets for form controls. - copied from MDN
  • *A button is empty , it has no value text. When navigating to a button, descriptive text must be presented to screen reader users to indicate the function of the button. * - source MDN. In this case you can use aria-label .
  • Skipping heading levels is not encouraged - Headings provide document structure and facilitate keyboard navigation by users of assistive technology. These users may be confused or experience difficulty navigating when heading levels are skipped.

  Happy coding

  1