IP-address tracker

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, well you can't really "hide" your api key since you are using it in your client-side code. Usually, fetching in some api usually goes in the backend so that it hides all of it. That is why I tend not to do some challenges that requires some api key.

  Apart from that. Little suggestion/s:

  • On your input, it would be better if you used fixed unit like rem so that it won't scale via the viewport. Right now it is using height: 7h and will cause to shift a lot.

  • Your button next to it needs to have some description. You can do this via adding some aria-label to the button or creating a descriptive text somewhere and using aria-describedby property on the button. Also the image inside it could have been used as a background only to the button, or using it in ::before or ::after

  Still good job on this ^^

  1

  ---

  

  Tejas•265

  @Tejas-117Posted over 3 years ago

  @pikamart Hey, thanks for the suggestions. I have updated my solution.

  1