IP Address Tracker

Community feedback

• 

  Nemanja Dragun•340

  @ndragun92Posted over 1 year ago

  Hello,

  Great job completing this challenge.

  Few things I did spot. There is w-screen h-screen in HTML which causes a horizontal slider to appear. I would suggest swapping that with w-full h-screen to get rid of that scroll

  Also, I know this is a test project but I would still suggest using .env variables for firebase credentials so no one else can use yours since they are currently visible by anyone in github. Also once things like that get submitted to git even if you delete them later, they will be present in git history.

  Also since it is Vue 3 I would suggest trying to use composition API and composables Another thing is that this.countries.location && this.countries.location.region can be shortened with optional params this.countries.location?.region

  Overall good job! Keep it up!

  Marked as helpful

  0