Atif Iqbal• 3,200
@atif-dev
Posted
Hi, congrats on completing the challenge. You did NICE.😍 Take care about following points:
- To avoid accessibility issue "All page content should be contained by landmarks" use code as :
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
(why main matters? Read here)
- In About section of repo, write brief description and include live link.
- It is preferred to use responsive units(
remfor font-size andemfor padding and margin)
Hope you will find this Feedback Helpful.
Marked as helpful
0
Alina Alexandra• 160
@AlinaAlexandraVizireanu
Posted
@atif-dev Hello, thank you very much for your feedback! I'll take into consideration your advice and I'll apply it to my next projects as well.😄
0
