ip address tracker (scss +javascript+ fetch+css+html)

Community feedback

• 

  P

  Jeremy Helsel•670

  @JIH7Posted over 1 year ago

  I think your code looks great and you have a very comprehensive solution! I also did this challenge recently. I don't know if this is better or worse overall, but rather than fully checking valid IP and domain formatting, I did a check to see if the input is all numbers and dots to determine whether to make a request for IP or domain. Then if the API returns an error I put the error message on screen. My solution's repo is here if you wanna compare!

  https://github.com/JIH7/iptracker

  The UI is also very crisp. The only issue I can find is that the map draws on top of the "result" div when clicked. I'm sure giving it a higher z-index value would fix this!

  Marked as helpful

  1
• 

  Hassan El Jebyly•490

  @hassaneljebylyPosted over 1 year ago

  thank you very much for the input, the reason I validate the input before sending the request is to not waste a request on an input I already know It's not valid, there's also a requests limit on the api hence the extreme measure 😅, the map drawing on top of the "result" div is intentional the mobile design is impossible because the result div covers the map, so I made it so it changes z-index on focus, was going to make a better solution tbh but was a bit in a hurry

  0

  ---

  

  P

  Jeremy Helsel•670

  @JIH7Posted over 1 year ago

  @hassaneljebyly Yeah I figured you were doing the full check to save requests. Honestly a great call considering this API has a limit.

  And that makes the map thing make more sense! I bet if you made it only behave that way on mobile it would actually be a great solution.

  Marked as helpful

  0