Design comparison
Solution retrospective
I am just a beginner and would appreciate any feedback.
Do I have good practices? What errors do I have? How could I improve my code?
Thanks <3
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hello there, MasterKrab! 👋
Nice work on this challenge! 🙌
The design of your solution is great—just one small thing is that there seems to be some extra white space below the map when the height of the screen goes above 900px.
Also, the search box won't allow me to search for domain names (like "www.google.com")—only IP addresses, I guess, so that might be something you want to look into (since the placeholder says, "Search for any IP address or domain"). 😉
Keep coding (and happy coding, too)! 😁
1@MasterKrabPosted over 3 years ago@ApplePieGiraffe Good point! Solved, thank you very much!
1@ApplePieGiraffePosted over 3 years ago@MasterKrab
Awesome—I just checked again, and it works fine, now! 👍
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord