Design comparison
Solution retrospective
My first frontend mentor challenge using React.
Community feedback
- @seezmashelePosted over 1 year ago
Hey Krzysztof, congrats on completing this challenge😀
I noticed the map and ip addresses keep on changing after searching. My guess is that the useEffect in "SearchBar.jsx" where you use fetchMap update again and again because useEffect runs when it's dependencies change.
useEffect(() => { fetchMap(); }, [input, fetchMap]);
I hope that helps.
The rest of the app is really well done. Good luck with the other challenges!
0@KrzysztofRozbickiPosted over 1 year ago@seezmashele Thank you very much for your reply! I assumed that it was the purpose of application - to show the searched IP and physical address and show it on map. What would you recommend changing or improving?
0@seezmashelePosted over 1 year agoHey @KrzysztofRozbicki , sorry my reply wasn't clear.
After I search something like google.com, the IP and map change many times with different addresses etc.
It's not all domains so who really know's what's going on 😅
I can't see anything else to recommend. Your app is solid in my opinion👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord