IP Address Tracker

Community feedback

• Account deleted

  Hello Andrius,

  Congratulations on your result, for the most part it is very good! Here is some quick feedback:

  1. Your solution only accepts an IP address and not a domain name as requested from the brief

  2. You shouldn't be using the deprecated var keyword in your js files, except under very, very specific circumstances. Use let or const instead. This is because var is not block scoped and as such can be changed anywhere from your application, for this application it's probably not a big deal, but in others, it could cause huge potential headaches, so it would best to break this bad habit now.

  3. You don't need to declare row on a Flex container unless you are changing it from a column in a media query for instance, by default Flex containers are set to row, in a large application this could save many lines of code and make your code less verbose.

  Apart from that good job!

  If you found this helpful please mark as helpful,

  Thank you

  1

  ---

  

  Andrius•130

  @AndriusM5Posted about 2 years ago

  @ashmaddenweb Thank you for your feedback, added search by domain functionality! More updates coming soon.

  0