Design comparison
Solution retrospective
Anyone with experience please share where I should improve and solution that I should come up with.
Community feedback
- @TheMrBombasticPosted over 2 years ago
Hi Ahmit, Congratulations on you solution:)
i cant tell you too much but... -your file repositories are empty.
-and because i just did the challenge myself, you can do the background of the slide in animation with an black picture, set an opacity, and use a filter on that on. If you wanted make it look differently...
0@DavidMorgadePosted over 2 years ago@TheMrBombastic He did upload everything to the repository but it's not in the main branch is all in the master branch.
Checked again, is a react project but he did only upload the build files!!
Please upload your development files so we can check your code and give you feedback!
Marked as helpful1@herojk64Posted over 2 years ago@DavidMorgade I have added new branch with react files that I used to build please take a look.
0@DavidMorgadePosted over 2 years ago@herojk64 Hello Amit sorry for the latest response didn't see that you commented out here!
I checked out a bit your react files, seems that you are doing good, divide your App in as much components you can and reuse them!, also nice approach with CSS Modules, not a thing you usually see on react begginers (did you got the idea from an online course?), also would recommend you to start using component, and start getting to react hooks (useState, useEffect, useContext...) etc!
Try this challenge using react, it will improve a lot your skills!
Marked as helpful1@herojk64Posted about 2 years ago@DavidMorgade not online course but just online youtube videos ideas just merging things here and there creating new ideas which already exists im sure. Comment like yours helps me look into new stuffs and just progress sorry i already took another challange and will do yours soon too :).
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord