intro-section-with-dropdown-navigation-main

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted over 2 years ago

  Hi ِAbdullah, it looks like your images aren't showing up. You'll just need a dot in front of the slash (as in, "./media/images/..."), and that should do it. You may want to edit the links in your JS as well.

  Good job on using Javascript! I'm looking at your code and also testing out the mobile nav; it looks like you have onclick for adding the show dropdown class and then you used mouseleave to remove the class. I probably would just use onclick for both actions just for consistency, and also sometimes it's hard to control hover actions for clicking where a slight move could affect another element. It's also a very interesting approach you took, in how you built your mobile side nav using JS. I'm a bit curious as to why you chose to use JS for responsiveness, but either way I think your code served its purpose, and now it just needs the images working!

  For responsive images, you may want to check out responsive images using the HTML picture element, which is what I use in my projects.

  Happy coding!

  Marked as helpful

  0

  ---

  

  ِAbdullah•730

  @9dorghamPosted over 2 years ago

  @elaineleung Thank you for reviewing my solution I really appreciate that you give me good advices. Thanks :)

  1