intro-section-with-dropdown-navigation

Community feedback

• 

  Ahmed El_Bald•1,020

  @Ahmed-ElbaldPosted over 2 years ago

  Hey Opeoluwa,

  I generally like your solution but I think it could be better with some touches:

  • All the transitions in the page happens all at a sudden. So it would be better if you added some transition-duration to those elements to make the page a little bit smoother .
  • If the dropdown is opened, you can add an option that the dropdown menu closes automatically when the user click outside it. (that's implemented in my solution)
  • In small screens, when the nav gets opened, the body's background-color gets changed while it could be better if you added an overlay that has the a height: 100vh; width: 0; and when the user opens the nav, this overlay's width gets changed to 100%. By doing that, This process will happen smoothly. If you don't know what I mean.. (that's also implemented in my solution).
  • You also have some issues with accessibility. I don't mind helping you solve them

  I hope you find my feedback beneficial. Thank You

  Marked as helpful

  1

  ---

  

  Opeoluwa•330

  @Opeoluwa-OgunlajaPosted over 2 years ago

  @Ahmed-Elbald Thank you very very much. I'll try and implement them 🙂. Thank you.

  0

  

  Opeoluwa•330

  @Opeoluwa-OgunlajaPosted over 2 years ago

  @Ahmed-Elbald I can use the same method for my sidenav for the dropdowns right?

  0

  

  Ahmed El_Bald•1,020

  @Ahmed-ElbaldPosted over 2 years ago

  @Opeoluwa-Ogunlaja Sorry what method do you mean ?

  0

  

  Opeoluwa•330

  @Opeoluwa-OgunlajaPosted over 2 years ago

  @Ahmed-Elbald Changing class names and using simple css transitions

  0

  

  Ahmed El_Bald•1,020

  @Ahmed-ElbaldPosted over 2 years ago

  @Opeoluwa-Ogunlaja Yeah u can use it anywhere as long as the CSS property is animatable

  1

  

  Opeoluwa•330

  @Opeoluwa-OgunlajaPosted over 2 years ago

  @Ahmed-Elbald Ok 😁👍. Thanks again!

  0

  

  Opeoluwa•330

  @Opeoluwa-OgunlajaPosted over 2 years ago

  @Ahmed-Elbald Ok 😁👍. Thanks again!

  0

  

  Ahmed El_Bald•1,020

  @Ahmed-ElbaldPosted over 2 years ago

  @Opeoluwa-Ogunlaja You are welcome

  1