intro-section-with-dropdown-navigation

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted 12 months ago

  Hi

  I’m afraid you are misusing aria-haspopup and aria-label here. The dropdowns should only have aria-expanded, no other aria attributes. It’s very important not to add aria-labels unnecessarily. These buttons already have a visible label. As soon as you change that label only for some users it will make the control inaccessible (eg voice control users could no longer say “click Features” as the label has been set differently)

  These are not menus. That is a totally different role, specifically for sofware menus like the file menu on word or other software

  Marked as helpful

  0
• 

  Matias Ludueña•1,990

  @matiasluduena23Posted 12 months ago

  Hi Joe! Good work! Just three advice that might help you.

  • In your titles use the function clamp to set differents values to your font-size. >You can check this video.
  • For your image you can set a max-height: 750px.
  • In your main you can use `display: flex; justify-content: center; align-items: center;

  Tried to avoid fixed sizes, and your website is going to be more dynamic hope this help you!

  Good code!

  Matias

  Marked as helpful

  0