Design comparison
Solution retrospective
Responsive. Code corrections are welcomed
Community feedback
- @nicodes-devPosted over 1 year ago
Hi Big-Norj! You did a good job with your solution although I found some mistakes in your code. First is that if you hover on the "Learn more" button, the font changes.
This is because you set it to font-family: bold
.hero button:hover { background-color: transparent; border: 1px solid black; color: grey; font-family: bold; // this should be font-weight: bold or 700 cursor: pointer; transition: all 1s; }
You should also only add transition to properties that you want to transition.
transition: all 1s;
You can add multiple transition by separating them by comma (,)
transition: background-color 250ms, color 250ms;
Another thing you may want to fix is your mobile nav appears when the width of the screen is at 900px. I would like to help you with it but your github repo is hard to clone. The problem is your solutions are added in multiple branch.
I suggest that in the future challenges. When you add new solutions, you add it all in the main branch.
Marked as helpful0@Kingnorj1Posted over 1 year ago@nicodes-dev Thank you so much i will do the changes needed
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord