intro-component-with-signup-form-master

Community feedback

• 

  Anar•700

  @anar-solPosted about 3 years ago

  Hello! The overall styling looks good, but I have some remarks:

  • Why not use the HTML5 built-in form validation? https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation

  • You are using a simple <input type='text'> for the email, and you are not checking if it's a well formed email.

  • You use hard codded error messages in your HTML code, what would you do to report two different error messages for one entry? (supposed to be the case for the email)

  • Instead of using inline css to style error stat, you could just add a css class (with JS) when there's an error.

  Marked as helpful

  1