intro-component-with-signup-form-master

Community feedback

• 

  P

  Abouelhouda Iliass•480

  @ilyesabPosted 8 months ago

  Hi @Nadine-Green, I think I know why your image doesn't show.

  in the file SCSS/Components/_sections.scss is where you're styling the main container and where you set the background image:

  main {
    background-image: url("../../images/bg-intro-desktop.png");
  }
  

  The path is correct since you're jumping one up to the SCSS and then one up to the root directory where the images folder exists. however the compiled index.css has the same code but it exists directly under the SCSS folder.

  So the path should be:

  main {
    background-image: url("../images/bg-intro-desktop.png");
  }
  

  Since Sass doesn't fix the path based on where the compiled file will be generated.

  It shouldn't work on your local machine on mine it works and I'm using live server. I'm assuming since live server notices that we're going up above the root directory it fixes the path. because if I open the html file without live server the background doesn't show. so just fix that line and it should work.

  Hope this was helpful.

  2

  ---

  

  Favour•2,160

  @Nadine-GreenPosted 7 months ago

  @ilyesab thank you for this recommendation, but I'm not sure on how to check if it works, should I unpublish and republish the site?

  1

  

  P

  Abouelhouda Iliass•480

  @ilyesabPosted 7 months ago

  @Nadine-Green not really I see you fixed it in _sections.scss. after you commit in github the frontend will be redeployed automatically. as you're using github-pages.

  However you didn't recompile the scss files to generate a new index.css. that step is not included by default in github-pages. it just uses the generated index.css file directly.

  You can either include the compilation of SCSS into the build pipeline which will require some github CI/CD knoweldge.

  Or the easy way recompile locally and commit wait a few seconds and the background image should show up.

  Marked as helpful

  1

  

  Favour•2,160

  @Nadine-GreenPosted 7 months ago

  @ilyesab thank you, i just checked it and it works

  1

  

  P

  Abouelhouda Iliass•480

  @ilyesabPosted 6 months ago

  @Nadine-Green glad to be of help!

  0