Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Intro-component-with-signup-form

Rai_Sama 380

@raisama21

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback are highly appreciated :)

Community feedback

David 8,000

@DavidMorgade

Posted

Hello Rai_Sama congrats on finishing the challenge! pretty good job!

If you don't mind I would like to give you some suggestions:

Your input for the password should have type='password' so it hides the characters when typing as usually real login page do (hacker tip, you can inspect any page html and set the input to type text and see the password if its save by any type of saving tool!).

Remember that for email validation you can either use two ways, doing it with Javascript and regular expressions (in my opinion, the best way, more easy to manipulate the dom with this), and also with the pattern html property of inputs!

Hope my feedback helps you, if you have any questions, don't hesitate to ask!, great job!

Marked as helpful

1

Rai_Sama 380

@raisama21

Posted

@DavidMorgade Thank you for the feedback it's my first time doing form so this was really helpful

1
PhoenixDev22 16,950

@PhoenixDev22

Posted

Hi Rai_Sama,

Excellent work! i have some suggestions regarding your solution:

  • Forms with proper inputs and labels are much easier for people to use. To pair the label and input, one way is an explicit label’s for attribute value must match its input’s id value. Input fields without accompanying labels can lead to accessibility issues for those who rely on screen readers. If a screen reader comes across an input field without a label it will try to find some accompanying text to use as the label. (To hide the label visually but present for assistive technology, you may use sr-only class ).
  • The input for the erroneous field is in bold and red. Validating forms using JavaScript
  • Thearia-live attributeis set on that error messageclass="error-message" to make sure that error message will be presented to everyone, including it being read out to ** screen reader users**.

Hopefully this feedback helps.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord