Intro-component-signup-challenge (HTML, CSS and JS)

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Lucas! 👋

  Congratulations on finishing this challenge! 🎉

  Some recommendations from me.

  • I recommend validating the email with Regular Expression (RegEx). The native HTML validation for the email is considered a@a as a valid email address.
  • Avoid using JavaScript to add styling (unless you've no other option). JavaScript allows you to change the CSS code using the style property. But, to make debugging easier and improve code maintainability, it’s best to avoid it. Use CSS classes instead for all the styling.
  • I recommend using all classes begin with js- to select DOM elements within the JavaScript. This will separate the styling and the functionaility. Keep in mind, that only use the js- classes only for JavaScript purposes.

  // Example
  const form = document.querySelector(".js-form");
  

  That's it! I hope this helps. 😊

  Marked as helpful

  0

  ---

  

  Lucas•70

  @lu0teroPosted over 2 years ago

  @vanzasetia Thanks for the advice! It helps me a lot! In future challenges I will use the "js-" to select DOM elements!

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @lu0tero You are welcome! 👍

  0