Intro-component-signup-card-form

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  LABELS 🔖:

  • input elements are having a label with empty content, those labels are not gonna work.

  ---

  • Instead you can use the html native attribute named aria-label

  ---

  • A aria-label is used to create a caption for a form control. The aria-label can be associated with a form control either implicitly by placing the control element inside the label element, or explicitly by using the for attribute

  ---

  • Effective form labels are required to make forms accessible. The purpose of form elements such as checkboxes, radio buttons, input fields, etc, is often apparent to sighted users

  ---

  • Even if the form element is not programmatically labeled. Screen readers users require useful form labels to identify form fields, So here using aria-label="{values}" attributes for input is enough to be accessible

  ---

  • Example:

  <input type="text" aria-label="First Name" placeholder="First Name" id="first-name" name="first-name" class="registration-form__input">
  

  ---

  • Now you can remove those label elements with sr-only classes, using aria-label makes the code clean also

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0