Intro Sign Up w/ GRID

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hi Paula, well done here in practicing what you learned! 🙂 In terms of feedback, I just have some quick comments:

  1. I think this was done well on the whole, especially in using grid areas! For the desktop view, instead of separating each item, I probably would have grouped the title and description together. This way, it might be possible to make the text part vertically centered in relation with the form like the design.

  2. Right now at around the breakpoint before the mobile view changes to desktop view, the form is looking pretty big! Instead of using just width: 87vw for the width in the main container, try width: min(87vw, 600px) so that the container won't stretch past a certain width, which in my example is 600px, but you can change that to your liking. Same thing goes for the desktop view when the breakpoint occurs; you can try something like width: min(87vw, 1100px).

  3. I'm viewing this on an average-sized laptop (basically not a big screen), and at desktop view, the top part of the promo is touching the top of the window, so maybe you can try adding some margin to prevent the component from touching the browser sides.

  Great work here, and keep going!!

  Marked as helpful

  0