Intro section with responsive dropdown using javascript
Design comparison
Solution retrospective
This took me longer than I would like to admit, just trying to align everything according to the design by guesstimating and especially when you are working on different size screens you get different results. I welcome any feedback.
Community feedback
- @DavidMorgadePosted about 2 years ago
Hello Hyron, congrats on finishing the challenge! pretty good job, the layout and the responsiveness are working perfectly!
I have just some little suggestions that can help with the user experience of your landing page:
-
You should make the entire button clickable for the dropdown, right now if I click the arrow it doesn't show the menu, also would be nice if the arrow changes directions like in the challenge files (adding a
transform: rotate(90deg)
onclick should do the job!). -
For the html you should try to structure all of your principal content on a
main
tag, then inside that main you can define thesections
, having your navbar on a<header>
tag is also a must! along with the logo and the buttons! (instead of having everything on your nav, just have the dropdowns and put that nav with the other elements on a header tag). This will improve the accesibility and the position for search engines in your application (wich is quite important for a landing page!).
Nothing more to say, your result is good and this are just little changes that you can maybe apply for future projects!
Hope my feedback helps you, if you have any questions, don't hesitate to ask!
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord