Intro Section with Dropdown Navigation with HTML CSS and JS
Design comparison
Solution retrospective
This one took me a while. I feel like I overdid it with with my id's and classes and naming conventions as I even had some difficulty in rereading my own code at times. The part that took me the most time was writing the javascrtipt and using grid in the desktop version. I would've liked to fixed some more bugs with the dropdown menus but I'm happy with it. thanks for any feedback or comments! :)
Community feedback
- @tesla-ambassadorPosted over 2 years ago
Hey Chris! Congratulations on completing this wonderful challenge! It's looking pretty solid and sharp. I also like that it's responsiveness is good! Here's a few pointers:
- You might want to add hover states to your buttons and some of your navigation links. This will make the website more interactive and it also gives a user a very good impression π
- You need to add an
alt
text to your images. This is because it tells the browser what image is being displayed and this can also help those using screen readers to know what image is being displayed on the website. It will also clear some of your HTML validation issues and accessibility issues - A
<ul>
or<ol>
only takes an<li>
as it's child element. So you can't have a<ul
> as a child element of a<ol>
this is bound to generate some HTML validation issues. - You might wanna use heading tags
(<h2> - <h6> )
in your<sections>
. In your case, you have two options, you can use<div>
instead of the<section>
because the div doesn't require you to add heading tags or you can make the headings to your sections<h2>
tags.
Happy coding and keep up the good work!π
Marked as helpful1@chintriagoPosted over 2 years ago@tesla-ambassador thanks for the feedback! it's very helpful.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord