Design comparison
Solution retrospective
Hello everyone! ヾ(≧▽≦*)o
Another challenge done~! For this challenge, It let practiced on implementing the navigation part. It's actually my first time making an actual responsive navigation so this is really hard to accomplish, but I managed to complete it.. phew~
I've struggled a lot on the CSS part and I feel like my CSS is really messy, and the drop-down part as well. If you have any feedback or suggestions please do let me know!
PS. sorry if it is not pixel perfect `(>﹏<)′
Thanks~ ( •̀ ω •́ )✧
Community feedback
- @fazzaamiarsoPosted over 2 years ago
Hello, Briuwu! What a great and clean solution! Nice work👍.
Just a quick tip on accessibility. On these elements:
<li className="navbar-items"><a aria-label="Careers" href="#">Careers</a></li> <li className="navbar-items"><a aria-label="About" href="#">About</a></li>
Using
aria-label
is considered redundant as you already have accessible text in them. One of ARIA main rules is to favor semantic HTML.Cheers!!
Marked as helpful1@BriuwuPosted over 2 years ago@fazzaamiarso I see, I'll keep that in mind! Thank you~ (≧▽≦)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord