Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Intro section with dropdown navigation Using React

@soufianeoualla

Desktop design screenshot for the Intro section with dropdown navigation coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


any feedback to improve my code.

Community feedback

@matiasluduena23

Posted

Hi SOUFIANEOUALLA’S! Good work!!! Just two advice.

  • Don't use an <a> tag inside a <button>. They have two different purpose a <button> is a click element to make some function en the web. An <a> tag is an element used to link to another website

  • Your button make the height jump on hover effect, that is because add border on it and your remove the border in the normal state. To avoid make the border tranparent.

.learn-more {
    padding: 1rem;
    width: 30%;
    border: 1px solid tranparent;  // use this
    outline: none;
    background-color: var(--Almost-Black);
    border-radius: 15px;
}

Hope this help you!

Good code!

Matias

0

@soufianeoualla

Posted

@matiasluduena23 Thank you

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord