Intro section with dropdown navigation | SCSS, JS and HTML

Community feedback

• 

  Furk•600

  @doganfurkanPosted over 1 year ago

  Firstly congrats, I think I've got some feedbacks for you:

  • Your "Learn more" button has a border of "1.5px" on hover. You shouldn't be splitting pixels into 2. Dimensions in pixels should be integers.
  • Again your "Learn more" button, could use a border with the color of the background, so that it wouldn't mess up the placement of the footer. What I'm trying to say is add a black border at start, so you wouldn't make it bigger on hover.
  • Your menu comes open on mobile. We usually don't see it like that in real life, do we?
  • You are giving display: none to the menu when closed. What about hiding it on the right, out of screen, rather than deleting it from the screen?
  • When i used inspect to have a look at your mobile version, i closed the menu and when i turned back to the desktop version menu was not there. It is related with your display none decision.

  1

  ---

  

  Gabriel Crispim•430

  @sirbiel100Posted over 1 year ago

  Hello!!

  Thank you so much for your feedback, it helped me a lot. I passed a entire night thinking how I would solve that but I finally did it! hahahahah.

  @doganfurkan

  0