intro-section-with-dropdown-navigation-main

Community feedback

• 

  Andrey•2,570

  @dar-juPosted about 1 month ago

  Hi manarbooo!

  Great job! I like your responsive layout and it's as close to the mockup as possible.

  There are a few things that could be fixed:

  • check the layout on a screen smaller than 840px, it looks good, but there is a horizontal scroll and you can see the mobile menu on the right. You can use display: none for it, but in this case the animation won't work. The best option is to add the line overflow-x: hidden; for body and everything will be ok
  • it would be cool if the "Features" and "Company" menu appeared not only by clicking on the arrows, but also on the text. It would be even cooler if the menu didn't have to be closed by clicking again, but, for example, by clicking anywhere outside this block.
  • when you click on the burger, it would be better if only the menu moved up, and the gray background just appeared. To do this, you need to separate the background and menu blocks, make the background block opacity
  • you used the <figure> tag for the image, but you connected the image itself via css background-image, this makes no sense. In general, this is a content image and it is better to use the <img> tag with a filled alt. You did the right thing for the logos below, but you need to add the alt attribute to them. For the burger menu and menu closing images, there should also be alt, since these are non-content images, the alt should be empty alt="", otherwise it will be an error.

  Otherwise, everything is great, good luck with your development!

  Marked as helpful

  0

  ---

  

  manarbooo•500

  @manarboooPosted about 1 month ago

  Hello there! I really appreciate you taking the time to fully review my solution and provide such detailed feedback. I'll make sure to take it into consideration. Thank you for your insights!.

  1