Andrés Gutiérrez Ramírez• 2,510
@AGutierrezR
Posted
Hello there 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
- To avoid content being fluid horizontally, you could use a
max-width: 1150pxandmargin-inline: autoon themain .hero .hero-container .contentselector. - You could do the same for the
main nav .nav-containerselector, but in this case, it is wider than the content. - You have two selectors with the same target with the same properties (
main .hero .hero-container .contentinheader.scssand.hero .hero-container .contentinhero.scss) you could refactor that and remove one of them. - To avoid elements from stretching vertically (like in the
main .hero .hero-container .content .left-content .sponsoresselector) you should addalign-items: center, this will keep elements from stretching vertically and will center them vertically
I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!
Happy coding!
Marked as helpful
1
Ali Mahmoud• 390
@AliMahmoud21
Posted
Oh man, thanks I agree with you, especially the first point and the third one I don't know why I insisted on using an extra selector and not using "max-width". I'll modify them as soon as possible and I'll try to fix the Responsive Design as well.
0
