Design comparison
Solution retrospective
Hello everyone,
Here is my solution for the " Intro section with dropdown navigation" challenge.
Any constructive comments are welcome.
Good coding !
Community feedback
- @PPechmannPosted about 2 years ago
Hi @Demyttenaere,
very well done on this challenge, I like it!
The only little improvements I would suggest, is to apply the eventlistener for the dropdowns, to the Features and Company text too, as users would most likely first click on the text instead of only the arrows.
You could also add en Eventlistener on the window, for when it resizes to remove all the dropdown classes. This way they will not stay open when changing screen size.
As a last point, I also suggest to toggle the classes for the dropdowns within the eventlistener functions. If you then click on one dropdown while the other one is open, the previous one closes automatically.
My solution is not perfect, but you can check it here to see what I mean.
Hope this little feedback helps!
Happy coding and happy weekend :)
Marked as helpful0@DemyttenaerePosted about 2 years agoHi @PPechmann,
Thank you very much for your comment because it's not the first time you've helped me with a project!
It's true that it could have been very nice to integrate a little more elements in my JS, I will try this on my next projects.
Thanks again for your advice!
Good coding !
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord