Design comparison
SolutionDesign
Solution retrospective
As always, feedback is highly appreciated :)
Community feedback
- @ErayBarslanPosted about 2 years ago
Hey there, excellent work with your solution! Design looks good, it's responsive and js sidebar functionality is clean. Some suggestions:
- There is a little gotcha on sidebar. Close and open buttons works as supposed to, but while it's open if the screen switches to desktop layout it would be better to close it by default which you can achieve by just adding
.show-sidebar {display: none;}
to your media query. - When the screen gets wider than 1440px container keeps growing since width is auto and content aligns to right side of screen breaking the design. You can use max-width and add auto to margin to center the container:
.container { max-width: 100rem; margin: 5rem auto; }
You can do the same to the header if you like. Aside these nothing I'd add. Excellent work again and happy coding :)
Marked as helpful0 - There is a little gotcha on sidebar. Close and open buttons works as supposed to, but while it's open if the screen switches to desktop layout it would be better to close it by default which you can achieve by just adding
- @munyite001Posted about 2 years ago
Thanks @Eray, really appreciate the helpful tips, I am working on them immediately
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord