Responsive Single Page Application | React | Tailwind | Vite

Community feedback

• 

  Eileen dangelo•1,600

  @EileenpkPosted almost 2 years ago

  Hi Tushar! your project looks great, I found it very clean and easy to read. I agree, react-router-dom is awesome! I checked the login functionality, and I found that, while it wouldn't let me just use test as an email because it was missing the @ symbol, test@ passed with no endpoint. While the <input type='email' > gives you some built-in validation, it might not be as robust as you would like. It might be helpful to add something like this for form validation on an email.

  function validateEmail(email) 
  {
   if (/^\w+([\.-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$/.test(email.value))
    {
      return (true)
    }
      alert("You have entered an invalid email address!")
      return (false)
  }
  

  If you found this helpful please mark it as such :) Let's connect on LinkedIn! www.linkedin.com/in/eileen-dangelo

  Marked as helpful

  1

  ---

  

  Tushar Biswas•4,080

  @itushPosted almost 2 years ago

  @Eileenpk Hello Eileen, Thank you very much for the feedback. I'm so glad to hear that the code was very clean and easy to read for you. Actually I selected this project to build a Single-Page-Application using react and react-router-dom. I couldn't agree more that JavaScript client-side-validation using RegExp is always more robust than built-in HTML validation. In fact, I've used something similar in one of my previous projects. But for this project I wanted to rely on basic HTML validation 😁😁😁

  Looking forward to receive more feedback from you in future. Happy Coding😄

  0