Design comparison
Solution retrospective
Simple create snap app Please give me free-back! Thank you for you time.
Community feedback
- @amalkarimPosted almost 2 years ago
Hi Enn Ko, congratulations for completing the challenge!
Please check at this line:
<img src="./images/image-hero-mobile.png" class="w-100" style="height: 450px;" alt="">
I think it's better that you only set its width using
class="w-100"
, or only set its height usingheight: 450px;
. Don't use them both, because it will make the image not proportional in mobile view.We could also add
alt
for the hero image because it's an important image and addingalt
will make it more accessible to all users. For example:<img src="./images/image-hero-mobile.png" class="w-100" alt="A curly hair man standing with a laptop on his hand in front of a yellow wall">
Please refer to this article from W3Schools about image accessibility for more explanation.
Hope this helps. Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord