FLEX

Community feedback

• 

  S MD suleman•3,530

  @sulemaan7070Posted almost 2 years ago

  hey @ilvdrskn😄, congratulations on completing the challenge here are a few suggestions to make your site better..

  1.Firstly the padding padding: 2em 5em on the button looks massive you can reduce that.. or if you are comfortable with pixels just go with pixels..

  2.On the .modal-menu use the property of fixed like this, this should keep the menu on the screen even when scrolling happens..

  .modal-menu {
      position: fixed;
  }
  

  3.the padding-left: 10em; on the main.main-info is pushing the box more than design..you can reduce that..

  4.As for the .picture div you can use the property of background-size: contain; to display full image..

  Hope that helps, Happy coding💯🔥👍🏻

  Marked as helpful

  1

  ---

  

  i_d_s_l•270

  @ilvdrsknPosted almost 2 years ago

  @sulemaan7070 Thanks for the advice, Minato! But I have questions about the background: if I change to contain, then on a mobile device it will float away with a decrease in the screen, but I have a fixed flex-basis, which is why between .text and .picture there is an empty space. How can this be fixed? And what can be said in general about the structure of an html document? Did I make it valid?

  1

  

  S MD suleman•3,530

  @sulemaan7070Posted almost 2 years ago

  @ilvdrskn when I removed the padding:10em and made the picture object-fit:contain ..and checked on the mobile.. it seemed okay.. give it a try.. and as for the footer you are using only 60% of its width on the mobile version also.. use 100% of footer width and reduce image sizes to fit them in a line

  Marked as helpful

  1