Design comparison
SolutionDesign
Solution retrospective
This project was so amazing, but i still have some difficult with the "hamburger" menu. Could someone help me? Thanks a lot!
Community feedback
- @Ao-chiPosted almost 2 years ago
Hi! You did great doing this challenge!
I saw your navigation menu on mobile version and it looks like it is not on top of the body. To make it appear on top you could add
z-index: 1
to your nav-menu class.Some tips for best practices.
- You should wrap your main contents into
<main>
element for more accessibility. - Add an alt attribute to your
<img>
elements like this<img src="/images/client-databiz.svg" class="clientimg" alt="hero banner">
- You should not wrap a
<button>
inside an<a>
element and vice versa. It is for accessibility practice. You can use either one of them. I you want the button to have a cursor pointer, you can just add this on your css stylingcursor: pointer
Hope this helps! Happy Coding~
Marked as helpful0 - You should wrap your main contents into
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord