Design comparison
SolutionDesign
Solution retrospective
i need a code review
Community feedback
- @sulemaan7070Posted almost 2 years ago
hey Adeolu Miracle😄, congratulations on completing the challenge... here are a few tips to make your site better.
1.your hero image seems squeezed, using the property
object-fit :contain
will prevent the images from being squeezed or stretched..2.I see that you have submitted link of
wrong repository
somthing nameddashboard-wireframe
.. you can fix that.3.Using the picture element for responsively switching between Images is considered as best practice
<picture> <source media="(min-width: 650px)" srcset="img_food.jpg"> <source media="(min-width: 465px)" srcset="img_car.jpg"> <img src="img_girl.jpg"> </picture>
more about picture element here📚
Hope that helps, happy coding🔥🔥
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord