Design comparison
Solution retrospective
inspired by Melvin Aguilar π§π»βπ» thanks for the beautiful challenge it's quiet a lot of code to write and i repeated my self multiple times but here we go at least idid my best π π
Community feedback
- @sulemaan7070Posted over 1 year ago
hey anass sanbaπ, you made a super cool site.. loved the dark mode transition... here are a few things you can do to make it better..
1.The mobile menu which you named as
.menu
is positioned absolutely... if I open the mobile menu and scroll it down it is scrollable.. to tackle that issue you can use.menu { position: fixed; }
2.Add an overlay in the background when the mobile-menu is opened.. more about the overlay hereπ
Everything else is superb!! happy codingπ―ππ»β
Marked as helpful1@sanba-anassPosted over 1 year ago@sulemaan7070 hey thank you so much for the valuable feedback iwill make a tweek to my code later πππ₯°
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord