Intro Section Challenge

Community feedback

• Account deleted

  I have one improvement for your navigation bar

  when it comes to the list elements (<li></li>), don't used margin left and right to the li itself if you used, there is a possibility you forgot to remove the last list margin-right or left you declared because of that the structure of navigation bar layout can be turn to mess if the width of navigation bar is not enough to fit all of the content.

  @media screen  and (min-width: 600px){
  // Always do this
  .main-menu {
  display: flex;
  gap: 2rem;
    }
  <=========================>
  
  // Never do this 
  .main-menu li {
  margin-right: 2rem;
  }
  
  // if ever you do this you need to include this code below
  // the purpose of this, is to prevent the navigation bar
  // for unexpected layout structure
  .main-menu li:last-child {
  margin-right: 0;
  }
  
  }
  

  Marked as helpful

  0

  ---

  

  Amos•170

  @AmossenkaoPosted about 2 years ago

  @okayda Thank you so much for your feedback. I do appreciate 🙏

  0