Intro Component with sign-up form

Community feedback

• 

  Ynnk•170

  @HYannickPosted over 4 years ago

  Nice work on this!

  Maybe use more readable class name for &__h1-> &__title and &__p-> &__description

  On the JS side there could need some refacto on the error handling part.

  Maybe wrap on the html side the errors like so:

  <div data-error='firstname'  class='error'>
      <img id="img1" src="./images/icon-error.svg" alt="error-icon" />
      <span>First Name cannot be empty</span>
  </div>
  

  and then on the js side use a validator function that will map the error depending of the form data provided, and add the error class with the right styles depending of the right data-attribute (I don't know if I am clear ahah)

  1

  ---

  

  Obi Zim•195

  @ObizimPosted over 4 years ago

  @HYannick Thank you Will definitely check it out

  0
• 

  Sahas saurav•745

  @SahasSauravPosted over 4 years ago

  reduce width of form it looks like stretch out and you have change the color of placeholder to red and by the good work

  0

  ---

  

  Obi Zim•195

  @ObizimPosted over 4 years ago

  @SahasSaurav Alright Thanks

  0