Submitted over 2 years ago
Intro component with sign-up form with pure CSS/JS
@ahmedAgawad
Design comparison
SolutionDesign
Solution retrospective
If you have any feedback please write a comment
happy coding 😊😊.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi, Ahmed Abdelgawad! 👋
Congratulations on completing this challenge! 🎉
It's great to see you finishing another challenge. I have some suggestions from me.
- Always use a meaningful element to wrap text content instead of
div
andspan
. So, I recommend wrapping the error message withp
element. - I recommend doing some research to make the error messages get pronounced by the screenreaders.
- For the
icon-error.svg
, you can try making it as the background image of theinput
element directly. I think it is much easier because you can control the error icon withbackground-position
.
That's it! I hope this helps. 😄
Marked as helpful0 - Always use a meaningful element to wrap text content instead of
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord