Intro component with sign-up form

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  HI! Your solution looks nice though there are a couple of things you can improve which I hope will be helpful! 😊

  Make sure to wrap the entire code in the main tag, in your case wrap your div where the class is “container” in the <main> tag and set the background on that main tag, not the div. It will help to remove report issues and improve accessibility as well. If you are using, for example, header or footer tags, you can place them outside the main tag.

  The article you use is not used correctly, I mean the one with the class "description". You should use a simple paragraph (p) tag. The article is used to create independent blocks of content but this text in this case is not independent, it comes along with the title as well.

  I recommend reading more about HTML tags: https://www.w3schools.com/tags/tag_comment.asp

  I also see you don’t have README. README is a very important aspect of making projects, especially if you want other people to see it. As the name says, it’s the first thing people read when interacting with the project, it is kind of a manual. You can include many things there like the languages you used, which dependencies you installed, what was the process like, and what did you achieve or learn. Frontend Mentor also has a pretty nice README template which you can use to tailor the one depending on your preferences.

  Marked as helpful

  1