Intro Component with signup form using vanilla javascript

Community feedback

• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Hey @Rohitgour03

  Congrats on completing the challenge. Your solution looks really good.

  As @ayoam suggested, that could be a possible solution, but given your project, I don't think you'd actually want to submit the form. You can recreate the submit effect by emptying the inputs after you click the submit button.

  Also, based on @ayoam suggestion, you don't need to write (allValid==true) - you can simply write if (allValid) as that variable will be converted to a boolean value automatically and checked for validity

  Marked as helpful

  1

  ---

  

  Rohit•330

  @Rohitgour03Posted almost 3 years ago

  @Remus432 Thanks, buddy 👍🙏 It's a really smart way of writing the conditional expression returning the boolean value. Thank you again for giving your feedback. 🔥

  0
• 

  Ayoub Amkhazzou•280

  @ayoamPosted almost 3 years ago

  Hey , well done!

  to fix the issue , add a boolean variable that equals false after each setError(), then at the bottom of the function check if all input are valid then add form.submit().

  function validateInputs(){

      let allValid = true;
  
       if (firstNameValue.length === 0) {
  
                  setError(firstName, "First Name cannot be empty");
  
                  allValid = false;
  
  	     } else {
  
                  setSuccess(firstName)
  
  	}
  
  ...
  
  if(allVAlid==true){form.submit();}	
  

  }

  hope this feedback helps.

  Marked as helpful

  1

  ---

  

  Rohit•330

  @Rohitgour03Posted almost 3 years ago

  @ayoam , Thanks, Ayoub 🙏 It's now working for me. Now I should practice including this type of flag-setting variable. This is a really good idea. 🔥

  1