Intro Component With Sign-Up Form using SASS

Community feedback

• 

  Abe•770

  @abe-m1Posted about 4 years ago

  Hi Gabriela, great job on the JavaScript, I noticed a few things,

  1. The HTML would look cleaner if there were no empty elements (<small> tags)

  In my solution to this challenge, I tried not to have any empty elements in the HTML, so if there is an error I created a new element with the error message and appended it to the DOM.

  It is hard to describe it in words, but if you look at my JS solution the code is commented.

  2. The SCSS looks good.

  There are two things that I implemented in my code which I find useful. I used BEM notation, so I could nest selectors in a way that was more readable .

  Also I used a Mixin for media queries, which lets me nest the media queries directly inside the CSS declarations instead of having one large media query at the end of the file.

  Marked as helpful

  1