Intro Component with Signup Form using HTML, CSS and JavaScript

Community feedback

• 

  Charfeddine•80

  @Gil2074Posted over 1 year ago

  I've been struggling with this challenge myself, here is my feedback, hopefully, it will be helpful. -the URL path you provided for the background image is wrong. You can notice it is not showing. -the email validation is not working properly, It could be the pattern. try removing the global regex because sometimes it results in unexpected behavior. -as for the label elements, you can select them using "element.nextElementSibling". its less coding lines there ^^. -could you please tell me why you are nesting conditions inside the else {} statement instead of using else if {} . I appreaciate it ^^

  0

  ---

  

  Zubair Abid•280

  @ZubairAbid101Posted over 1 year ago

  • The URL not working is an interesting problem I hadn't noticed. The URL works fine on the local server, yet for some reason it doesn't work on GitHub pages.
  • The email validation works fine. I just restricted it in my regular expression to be a specific number of characters.
  • As for the else if question, using else if would have needed me to include two conditions rather than one and based on how my code works that would make it slightly more difficult to read. (plus I couldn't be bothered)
  • Thanks for the "element.nextElementSibling" tip

  1