Intro component with sign-up form using bootstrap

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Nice work on this challenge Sven and congrats on submitting your first solution! The background image isn't currently showing up. After taking a look at your code it looks like you're just missing a . at the beginning of the file path, so it should be ./images as opposed to /images.

  Keep up the great work!

  0

  ---

  

  Sven Feeleus•490

  @n3vsxPosted about 5 years ago

  @mattstuddert Ah thanks for the feedback! Didn't notice since locally it takes the background with it that way

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @n3vsx no worries! Your solution looks really good! 👍

  1
• 

  argel omnes•1,800

  @argelomnesPosted about 5 years ago

  Hey Sven,

  I like how responsive this is. Is your repo private? I'm getting a 404. Some thoughts:

  • at the moment the form is touching the bottom edge for smaller devices. Consider adding a space to the bottom before breaking to 768px.

  • <blockquote> is meant for quotes. I suggest using `div` or `p` for the 'Try it free 7 days' block instead.

  0

  ---

  

  Sven Feeleus•490

  @n3vsxPosted about 5 years ago

  @argelomnes Thanks for the feedback! Yes i always used the <p> tag but i wanted to try something new haha

  0

  

  Sven Feeleus•490

  @n3vsxPosted about 5 years ago

  @argelomnes I re-added the link to the repository btw

  0

  

  argel omnes•1,800

  @argelomnesPosted about 5 years ago

  experimenting is cool ☺

  1