intro-component-with-signup-form

Community feedback

• 

  Sinisa Vukmirovic•1,690

  @SinisaVukmirovicPosted almost 2 years ago

  Hello!

  Look almost identical. Good job!

  Not a lot I could change... Clean code, very readable, nice folder structure...

  Only thing I could say is to use more semantic elements, not just <main>. Some of those <div>s could be replaced with <section>s.

  Good luck in the future!

  Marked as helpful

  1

  ---

  

  Sami NASRI•240

  @SilverWings47Posted almost 2 years ago

  @SinisaVukmirovic Thank you for the feedback, i'll get those changes you suggested implemented asap.

  1
• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  Looks nice but I would also add validation names, so it doesn't accept numbers, and add some length validation for password because if I write just one letter it shouldn't be correct 😊

  Marked as helpful

  1

  ---

  

  Sami NASRI•240

  @SilverWings47Posted almost 2 years ago

  @catherineisonline Appreciate the feedback, i will add those validation constraints asap.

  0