Intro component with sign-up form solution

Community feedback

• 

  P

  Krishna Vishwakarma•1,390

  @KrishnaVishwakarma1595Posted about 1 year ago

  Hey, @romannery

  Congrats on completing the challenge. Your solution looks great! I've some points for you

  • When we submit an empty form, the email field gets the input filled automatically with this value email@example/com. I think that should be empty too like other fields.

  • If there are no labels for the input then we should provide the label by the aria-label attribute for the inputs.

  • Although the .error-msg is hidden using display: none, but it could be read by screen readers, you must provide an aria-hidden="true" to all span for error messages.

  • When we fill in all the inputs and hit the submit button, you should reset the form and show the successful alert message using javascript alert() or you can create your custom message and show it.

  I hope these points will help you to improve. Nice solution. Keep mentoring!

  Happy Coding

  Marked as helpful

  1

  ---

  

  Roman Herrera Nery•110

  @romanneryPosted about 1 year ago

  Thanks for the feedback!

  1