Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Intro component with sign-up form solution

@romannery

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P

@KrishnaVishwakarma1595

Posted

Hey, @romannery

Congrats on completing the challenge. Your solution looks great! I've some points for you

  • When we submit an empty form, the email field gets the input filled automatically with this value email@example/com. I think that should be empty too like other fields.

  • If there are no labels for the input then we should provide the label by the aria-label attribute for the inputs.

  • Although the .error-msg is hidden using display: none, but it could be read by screen readers, you must provide an aria-hidden="true" to all span for error messages.

  • When we fill in all the inputs and hit the submit button, you should reset the form and show the successful alert message using javascript alert() or you can create your custom message and show it.

I hope these points will help you to improve. Nice solution. Keep mentoring!

Happy Coding

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord