Intro component with sign-up form Solution

Community feedback

• 

  Arseniy•170

  @ArseniyXPosted over 1 year ago

  Hello, good job. Design bugs:

  1. when wrong password or email format its show: * cannot be empty message instead of wrong format message
  2. first name and last name accepting numbers

  ---

  Code to improve:

  1. You manipulating the DOM directly without any framework/library that aren't a good choice
  2. You doing complex condition like:

  !firstName.classList.contains("error") &&
          !lastName.classList.contains("error") &&
          !email.classList.contains("error") &&
          !password.classList.contains("error")
  

  inside the if statement, you can put this logic to function name isValidForm or something and then use it in if statement.

  3. you use wrong convention for css vars --Red needs to be something like --danger-color or --error-color
  4. let namePattern = /^[A-Za-z]+$/; should be const from the context
  5. remove unused comments like: // inputFieldName.nextElementSibling.style.display = "block"; or add // TODO: if you wanna do something with that later

  0