@Jagholin
Posted
Nicely done!
There isnt really much to criticize, most of the following are just suggestions:
- I see that you are using create-react-app for your project. It has many problems and is no longer a recommended way to start React projects. For an easy-to-use replacement, I suggest ViteJS
- Your
<label>
sfor
attribute should point to anid
of an element being labeled, not toname
. - I suggest learning these React hooks:
useMemo
,useCallback
anduseId
. They are easy to use and would be helpful in your app - the first two memoize values and functions, and the third generates uniqueid
s so that you dont have to do it yourself. @import
rules in SCSS are deprecated. Its recommended to use@use
instead.
Otherwise, great job!
@durgeshraju
Posted
@Jagholin Thanks so much for your valuable 🙏 feedback. Sure next I will follow the points you mentioned.