Design comparison
Solution retrospective
It's natural to have some areas of uncertainty or ambiguity in code, especially when working on complex projects or using new technologies. In such cases, it's helpful to consult relevant documentation, online resources, or more experienced developers for guidance. It's also a good practice to leave comments in your code to explain any unclear or convoluted logic, making it easier for others to understand and maintain in the future.
Community feedback
- @JagholinPosted over 1 year ago
Nicely done!
There isnt really much to criticize, most of the following are just suggestions:
- I see that you are using create-react-app for your project. It has many problems and is no longer a recommended way to start React projects. For an easy-to-use replacement, I suggest ViteJS
- Your
<label>
sfor
attribute should point to anid
of an element being labeled, not toname
. - I suggest learning these React hooks:
useMemo
,useCallback
anduseId
. They are easy to use and would be helpful in your app - the first two memoize values and functions, and the third generates uniqueid
s so that you dont have to do it yourself. @import
rules in SCSS are deprecated. Its recommended to use@use
instead.
Otherwise, great job!
0@durgeshrajuPosted over 1 year ago@Jagholin Thanks so much for your valuable 🙏 feedback. Sure next I will follow the points you mentioned.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord